Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] Update the checksums for libuv #43139

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Nov 18, 2021

Here is the script used to generate this pull request:

cd $(mktemp -d)
git clone git@github.com:JuliaLang/julia.git
cd julia
git checkout release-1.6
git checkout -B dpa/1.6-refresh-libuv-checksums
make -f contrib/refresh_checksums.mk libuv
git add -A
git commit -m "[release-1.6] Update the checksums for libuv"
git push -f origin dpa/1.6-refresh-libuv-checksums

@DilumAluthge DilumAluthge added the kind:release Release management and versioning. label Nov 18, 2021
….mk` script did not delete them automatically)
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ararslan ararslan added the status:merge me PR is reviewed. Merge when all tests are passing label Nov 18, 2021
@ararslan
Copy link
Member

Actually, sorry to ask this but could we make this a PR against master then backport the commit to 1.6? Seems the checksums are similarly incorrect on master.

@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Nov 18, 2021
@DilumAluthge DilumAluthge marked this pull request as draft November 18, 2021 22:39
@DilumAluthge DilumAluthge marked this pull request as ready for review November 18, 2021 22:42
@DilumAluthge
Copy link
Member Author

I think the checksums are actually correct on master. When I run make -f contrib/refresh_checksums.mk libuv on master, there are no changes.

@ararslan
Copy link
Member

think the checksums are actually correct on master.

I think these are the old ones: https://github.com/JuliaLang/julia/blob/master/deps/checksums/libuv#L33-L34

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Nov 18, 2021

I think those are actually the correct ones for master, though.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Nov 18, 2021

An easy way to verify is to do make USE_BINARYBUILDER=0 and then check that the working directory is clean.

Actually, we have a once-daily scheduled Buildkite build that does a make USE_BINARYBUILDER=0 build off of the latest version of the master branch. If you look at the logs for a recent build of that (https://buildkite.com/julialang/julia-master-scheduled/builds/334#28d32674-d15e-48c1-8638-fdf9e0c91850), you'll see that the working directory is clean.

@ararslan
Copy link
Member

This took me a lot more thinking than I think was warranted but I've finally managed to un-confuse myself. You're right, this only needs to be applied to release-1.6.

@ararslan ararslan added the status:merge me PR is reviewed. Merge when all tests are passing label Nov 18, 2021
@DilumAluthge
Copy link
Member Author

I only checked master. Is release-1.7 good, or does it need to be updated?

@ararslan
Copy link
Member

1.7 is good.

@ararslan ararslan merged commit bef924e into release-1.6 Nov 19, 2021
@ararslan ararslan deleted the dpa/1.6-refresh-libuv-checksums branch November 19, 2021 00:51
@oscardssmith oscardssmith removed the status:merge me PR is reviewed. Merge when all tests are passing label Nov 19, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* [release-1.6] Update the checksums for libuv

* Manually delete the old libuv checksums (since the `refresh_checksums.mk` script did not delete them automatically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants