-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] Update the checksums for libuv #43139
Conversation
….mk` script did not delete them automatically)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Actually, sorry to ask this but could we make this a PR against master then backport the commit to 1.6? Seems the checksums are similarly incorrect on master. |
I think the checksums are actually correct on |
I think these are the old ones: https://github.com/JuliaLang/julia/blob/master/deps/checksums/libuv#L33-L34 |
I think those are actually the correct ones for master, though. |
An easy way to verify is to do Actually, we have a once-daily scheduled Buildkite build that does a |
This took me a lot more thinking than I think was warranted but I've finally managed to un-confuse myself. You're right, this only needs to be applied to release-1.6. |
I only checked master. Is release-1.7 good, or does it need to be updated? |
1.7 is good. |
* [release-1.6] Update the checksums for libuv * Manually delete the old libuv checksums (since the `refresh_checksums.mk` script did not delete them automatically)
Here is the script used to generate this pull request: