Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] Set VERSION to 1.6.4 #43133

Merged
merged 1 commit into from
Nov 19, 2021
Merged

[release-1.6] Set VERSION to 1.6.4 #43133

merged 1 commit into from
Nov 19, 2021

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan added the kind:release Release management and versioning. label Nov 18, 2021
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ararslan
Copy link
Member Author

FreeBSD builder "failure" (build status is red but this check doesn't prevent the builder from building and passing along to the tester, which succeeded):

ERROR: The working directory is dirty.
Output of git status:
On branch refs/pull/43133/merge
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	deps/checksums/libuv-fb3e3364c33ae48c827f6b103e05c3f0e78b79a9.tar.gz/
nothing added to commit but untracked files present (use "git add" to track)

I think this is because we're still setting USE_BINARYBUILDER_LIBUV=0 on buildbot to work around an issue that's since been fixed and backported (#41900). However, the checksum there that's causing the issue appears to be for a different version of libuv than the one in use. Does anyone know what might be going on there? Perhaps @staticfloat and/or @DilumAluthge?

(Also @DilumAluthge, I think we can remove the USE_BINARYBUILDER_LIBUV=0 setting on buildbot now.)

@DilumAluthge
Copy link
Member

However, the checksum there that's causing the issue appears to be for a different version of libuv than the one in use.

The checksums should be fixed by #43139

@DilumAluthge
Copy link
Member

(Also @DilumAluthge, I think we can remove the USE_BINARYBUILDER_LIBUV=0 setting on buildbot now.)

I agree that it's almost certainly safe to do so, but just to be extra cautious, maybe we can wait until the 1.7.0 release process has finished before we make that change? Just to avoid breaking the Buildbots in the middle of the release process.

@DilumAluthge
Copy link
Member

(Also @DilumAluthge, I think we can remove the USE_BINARYBUILDER_LIBUV=0 setting on buildbot now.)

I agree that it's almost certainly safe to do so, but just to be extra cautious, maybe we can wait until the 1.7.0 release process has finished before we make that change? Just to avoid breaking the Buildbots in the middle of the release process.

JuliaCI/julia-buildbot#255

@Sacha0
Copy link
Member

Sacha0 commented Nov 19, 2021

🎉 Thanks for all of your efforts folks!

staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants