-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce reliance on promotion operations via container typing #37088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool stuff!
master: Sysimage built. Summary:
Total ─────── 44.593185 seconds
Base: ─────── 18.240267 seconds 40.9037%
Stdlibs: ──── 26.351632 seconds 59.0934%
JULIA usr/lib/julia/sys-o.a
Generating precompile statements... 30/30
Executing precompile statements... 1771/1782
Precompilation complete. Summary:
Total ─────── 85.293917 seconds
Generation ── 58.616914 seconds 68.7234%
Execution ─── 26.677004 seconds 31.2766%
LINK usr/lib/julia/sys.so
tim@diva:~/src/julia-master$ ls -l usr/lib/julia/sys.so
-rwxr-xr-x 1 tim holy 148227920 Aug 17 15:28 usr/lib/julia/sys.so On a branch that merges all the PRs I've submitted today: Sysimage built. Summary:
Total ─────── 42.541928 seconds
Base: ─────── 17.358497 seconds 40.8033%
Stdlibs: ──── 25.181829 seconds 59.193%
JULIA usr/lib/julia/sys-o.a
Generating precompile statements... 30/30
Executing precompile statements... 1652/1663
Precompilation complete. Summary:
Total ─────── 79.426395 seconds
Generation ── 55.432791 seconds 69.7914%
Execution ─── 23.993604 seconds 30.2086%
LINK usr/lib/julia/sys.so
tim@diva:~/src/julia-master$ ls -l usr/lib/julia/sys.so
-rwxr-xr-x 1 tim holy 144046664 Aug 17 15:44 usr/lib/julia/sys.so So:
Not too shabby for a couple days of digging with Cthulhu. |
KristofferC
reviewed
Aug 18, 2020
KristofferC
approved these changes
Aug 18, 2020
While building Julia, we have a *lot* of calls to promote, often with abstract types. This short-circuits most of these by declaring the container type at the outset. This has one user-visible outcome, improved inference for `walkdir`.
c339146
to
c588775
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
…ng#37088) While building Julia, we have a *lot* of calls to promote, often with abstract types. This short-circuits most of these by declaring the container type at the outset. This has one user-visible outcome, improved inference for `walkdir`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building Julia, we
havehad a lot of calls to promote, often with abstract types. This short-circuits most of these by declaring the container type at the outset.This has one user-visible outcome, improved inference for
walkdir
.After my complete PR series is submitted, I'll post some benchmarks here on the impact on building Julia itself. Obviously no one PR accounts for the whole thing, but this one may be as good a place as any to deposit this info.