Improve consistency of Dict types & construction #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
added a commit
that referenced
this pull request
Aug 18, 2020
This is the array equivalent of #1968
timholy
force-pushed
the
teh/dict_types
branch
from
8174ecd to
b780cd5
Compare
timholy
added a commit
that referenced
this pull request
Aug 18, 2020
This is the array equivalent of #1968
|
Some of the artifact code might move to Base (become a new stdlib) in 1.6 so we should make sure that improvements here are also transferred to that. cc @staticfloat |
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2020
This is the array equivalent of #1968
KristofferC
reviewed
Aug 19, 2020
|
Something is weird with the Pkg server so the CI that runs with them seems to fail. |
timholy
force-pushed
the
teh/dict_types
branch
from
b780cd5 to
728b1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines some aliases and otherwise increases consistency in Dict types. Note that in some cases the final result is no different, but this avoids an unnecessary conversion by creating the Dict to be of the correct type at the outset. Essentially the Pkg equivalent of JuliaLang/julia#37088.