Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some GCLowering cleanup and add support for FCAs #33389

Merged
merged 2 commits into from
Oct 24, 2019
Merged

some GCLowering cleanup and add support for FCAs #33389

merged 2 commits into from
Oct 24, 2019

Commits on Oct 21, 2019

  1. [GCLowering] Try to conceptually simplify numbering/lifting code. 

    Try to consolidate the code to share common sections between scalar and
vector inputs (in preparation for adding other aggregates).

Also fixes a lost root bug:
if a select or phi used a value from a select or phi, it would fail to root it.

Adds support for handling vectorized select condition in LiftSelect.
    @vtjnash
    vtjnash committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    4776a8d View commit details
    Browse the repository at this point in the history

  2. [GCLowering] consolidate vector and union handling 

    Permit handling any value with the same numbering scheme, not just Vector and Union (would also handle scalars, even though those typically go through a special case).
    @vtjnash
    vtjnash committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    3bf20e6 View commit details
    Browse the repository at this point in the history