some GCLowering cleanup and add support for FCAs #33389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/codegengc-cleanup
branch
2 times, most recently
from
0f34325
to
0f3c69b
Compare
vtjnash
force-pushed
the
jn/codegengc-cleanup
branch
from
0f3c69b
to
abd12a9
Compare
vchuravy
reviewed
Oct 1, 2019
vchuravy
reviewed
Oct 1, 2019
vtjnash
force-pushed
the
jn/codegengc-cleanup
branch
from
abd12a9
to
b3cd1b8
Compare
|
Perhaps cherry-pick the |
Keno
reviewed
Oct 5, 2019
Keno
reviewed
Oct 5, 2019
vtjnash
force-pushed
the
jn/codegengc-cleanup
branch
3 times, most recently
from
ca6f911
to
fd69fe4
Compare
Try to consolidate the code to share common sections between scalar and vector inputs (in preparation for adding other aggregates). Also fixes a lost root bug: if a select or phi used a value from a select or phi, it would fail to root it. Adds support for handling vectorized select condition in LiftSelect.
Permit handling any value with the same numbering scheme, not just Vector and Union (would also handle scalars, even though those typically go through a special case).
vtjnash
force-pushed
the
jn/codegengc-cleanup
branch
from
fd69fe4
to
3bf20e6
Compare
vtjnash
changed the title
|
Will merge ~tomorrow, if no comments. |
|
Keno did leave some comments that appear to be unaddressed. If they're not relevant maybe comment why they're not? Edit: I see they're outdated. I find it helpful to use GitHub's ability to mark conversations as resolved so that no-longer-relevant comments don't linger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for some future work, change some representations and cleanup some code.