Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix performance regression in broadcasting in some cases #33079

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

KristofferC
Copy link
Member

Fixes the slowdown of array arithmetic reported in #32985 (comment).

@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks("arithmetic", vs = ":master")

@mbauman
Copy link
Member

mbauman commented Aug 26, 2019

Ah, this makes more sense — I was kinda surprised that #33007 was sufficient.

@KristofferC
Copy link
Member Author

KristofferC commented Aug 26, 2019

#33007 was for a totally different regression (the one that improved in the benchmark run in that PR).

@KristofferC KristofferC added this to the 1.3 milestone Aug 26, 2019
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC KristofferC reopened this Aug 26, 2019
@KristofferC KristofferC merged commit 56fdb19 into master Aug 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the kc/array_math_perf branch August 26, 2019 19:03
KristofferC added a commit that referenced this pull request Aug 26, 2019
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants