Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some broadcast patterns to avoid allocations #33007

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Conversation

KristofferC
Copy link
Member

Fixes the memory regression in #32985 (comment) for broadcasting array.

@KristofferC KristofferC added this to the 1.3 milestone Aug 21, 2019
@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks("broadcast", vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC
Copy link
Member Author

Hm, I guess the test fails because of tests running with boundschecks or something. I'll just remove the test since we have a benchmark for it.

@fredrikekre fredrikekre merged commit 191f2ae into master Aug 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the kc/alloc_bcast branch August 21, 2019 14:54
@mbauman mbauman changed the title fix and test that a certain broadcast pattern doesn't allocate fix some broadcast patterns to avoid allocations Aug 21, 2019
@mbauman mbauman added the performance Must go faster label Aug 21, 2019
KristofferC added a commit that referenced this pull request Aug 25, 2019
@KristofferC KristofferC mentioned this pull request Aug 25, 2019
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants