Explicitly list types in iszero test #20028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
approved these changes
Jan 14, 2017
stevengj
reviewed
Jan 14, 2017
| for T in [Float16, Float32, Float64, BigFloat, | ||
| Int8, Int16, Int32, Int64, Int128, BigInt, | ||
| UInt8, UInt16, UInt32, UInt64, UInt128, | ||
| Rational] |
There was a problem hiding this comment.
This makes me realize that we could use iszero(x::Rational) = iszero(x.num), which saves a comparison compared to the fallback method that does == 0
There was a problem hiding this comment.
Rather than including Rational in this list, I would check iszero(Rational{T}(0)) if T <: Integer in the loop.
stevengj
reviewed
Jan 14, 2017
| for T in [Float16, Float32, Float64, BigFloat, | ||
| Int8, Int16, Int32, Int64, Int128, BigInt, | ||
| UInt8, UInt16, UInt32, UInt64, UInt128, | ||
| Rational] | ||
| @test iszero(T(0)) | ||
| @test iszero(Complex{T}(0)) |
There was a problem hiding this comment.
If T<:AbstractFloat, we should also check iszero(T(-0.0)) and iszero(Complex{T}(-0.0))
ararslan
force-pushed
the
aa/iszero-test
branch
from
e03d088 to
1a2755a
Compare
|
Great ideas, @stevengj! I've incorporated the changes mentioned in your comments. Thanks! |
|
How are things looking now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses @tkelman's comment in #19950 (comment). I've restructured the
iszerotests such that the types are explicitly listed out. I've also consolidated more of the other tests into the loop.