Explicitly list types in iszero test (#20028)

* Add a method for iszero(::Rational) * Explicitly list types in iszero test
JuliaLang · Jan 15, 2017 · cf99703 · cf99703 · nanosoldier · Jan 15, 2017
1 parent ce5a62a
commit cf99703
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/base/rational.jl b/base/rational.jl
@@ -398,3 +398,5 @@ end
 function ^{T<:Rational}(z::Complex{T}, n::Integer)
     n >= 0 ? power_by_squaring(z,n) : power_by_squaring(inv(z),-n)
 end
+
+iszero(x::Rational) = iszero(numerator(x))
diff --git a/test/numbers.jl b/test/numbers.jl
@@ -2867,14 +2867,19 @@ end
 
 @testset "iszero" begin
     # Numeric scalars
-    for T in Iterators.flatten(subtypes.([AbstractFloat, Signed, Unsigned]))
+    for T in [Float16, Float32, Float64, BigFloat,
+              Int8, Int16, Int32, Int64, Int128, BigInt,
+              UInt8, UInt16, UInt32, UInt64, UInt128]
         @test iszero(T(0))
         @test iszero(Complex{T}(0))
+        if T <: Integer
+            @test iszero(Rational{T}(0))
+        elseif T <: AbstractFloat
+            @test iszero(T(-0.0))
+            @test iszero(Complex{T}(-0.0))
+        end
     end
-    @test iszero(BigFloat(0))
     @test !iszero(nextfloat(BigFloat(0)))
-    @test iszero(BigInt(0))
-    @test iszero(0//1)
 
     # Array reduction
     @test !iszero([0, 1, 2, 3])