Provide 0.6 implementation of collect for previous releases #350
Conversation
|
Cross-links: JuliaLang/julia#21257, JuliaIO/ImageMagick.jl#85. |
| @@ -1471,6 +1471,20 @@ else | |||
| using Base: StringVector | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/21257 | |||
| if v"0.5.0" <= VERSION < v"0.6.0-pre.beta.28" | |||
There was a problem hiding this comment.
OffsetArrays in its modern form only exists for 0.5 and above, though it's nice that older versions are installable on 0.4 and thus avoid giving us an error just from test/REQUIRE. Moreover, I'm not sure the necessary copy! method was available on 0.4. In general any support that 0.4 would have for arrays with nontraditional indices would be a fluke, and no one should even try to use them; this test is only relevant on 0.5 and above.
There was a problem hiding this comment.
It wasn't the release that made this method relevant though...
There was a problem hiding this comment.
Do we really want to be encouraging 0.5 pre-releases at this point?
There was a problem hiding this comment.
Note that in the README I specified that Compat.collect is for 0.5 and above.
There was a problem hiding this comment.
encourage no, but Compat's job is to work on as much of its supported version range as possible
There was a problem hiding this comment.
"even on 0.5" isn't the clearest way of phrasing that
* Remove at-compat for type aliases Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Nullable construction Was added in #287, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Foo{<:Bar} sugar Was added in #317 (and #336), now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for index styles Was added in #329, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for type declarations Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove unused at-compat helper functions * Remove README entries for removed at-compat functionality * new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372) * Remove `Compat.collect(A)` Was added in #350 and #351, now obsolete as no longer required on minimum supported Julia version 0.6.
No description provided.