Fix for removal of limit_output #212
Conversation
| key = expr.args[3] | ||
| if (((isa(key, QuoteNode) && key.value == :limit) || | ||
| (isa(key, Expr) && key.head == :quote && key.args[1] == :limit)) | ||
| && expr.args[4] == false) |
There was a problem hiding this comment.
more readable if line continuations of block openers are indented one extra level IMO, so it's set off from the body
There was a problem hiding this comment.
I'd have sacrificed the vertical alignment of the parens rather than adding a bunch of spaces between if and the start of the condition, but good enough
|
Is there anything we could try to make |
|
Maybe rewrite it as In some places, BenchmarkTools has whole separate sections for printing on 0.4. This may therefore be the best that's possible. |
This does something useful only for multiple versions of julia-0.5, since `limit_output(io)` was introduced (+1936) and then removed (+4305). Prior to that, you couldn't call `limit_output` on an `io` object. For earlier julia versions, this just evaluates as `false`. For, e.g., BenchmarkTools, it seems important to be able to support a range of julia-0.5 versions.
|
This is all green. Good to go? |
|
How urgently is this needed? I usually like to give Yichao, Milan et al a chance to review things here since they have a pretty good eye. |
|
That's fine, I was just pinging to let you know of the update. |
|
See also JuliaCI/BenchmarkTools.jl#9 |
|
Oh right should this have a readme item? |
* Remove at-compat for type aliases Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Nullable construction Was added in #287, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Foo{<:Bar} sugar Was added in #317 (and #336), now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for index styles Was added in #329, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for type declarations Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove unused at-compat helper functions * Remove README entries for removed at-compat functionality * new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372) * Remove `Compat.collect(A)` Was added in #350 and #351, now obsolete as no longer required on minimum supported Julia version 0.6.
This is only needed to support multiple versions of julia-0.5, since
limit_output(io)was introduced (+1936) and then removed (+4305).For, e.g., BenchmarkTools, it seems important to be able to support a range of julia-0.5 versions.