Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow broadcast errors to surface later. #491

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Allow broadcast errors to surface later. #491

merged 3 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. Allow broadcast errors to surface later. 

    We are currently checking for `isconcretetype`, which is too limiting, as
e.g. CUDA.jl supports isbits-union arrays. Checking for `allocatedinline`
would be better, but let's just do away with the check entirely and have
the array constructor fail in the presence of unsupported element types.
This is better anyway, as some back-ends may not support isbits-unions.

We do however still check for Union{}, as that isn't allocated inline
so would fail array construction. By using Nothing there instead, we give
the GPU kernel (which is expected to throw an error) the chance to execute
and report an exeception dynamically. This also makes it possible to
trace a broadcast invocation under, e.g., Cthulhu.
    @maleadt
    maleadt committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8e81b7a View commit details
    Browse the repository at this point in the history

  2. Upgrade to Julia 1.8.

    @maleadt
    maleadt committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1410f8c View commit details
    Browse the repository at this point in the history

  3. Disable test.

    @maleadt
    maleadt committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    30a96d9 View commit details
    Browse the repository at this point in the history