Allow broadcast errors to surface later. #491
Conversation
We are currently checking for `isconcretetype`, which is too limiting, as
e.g. CUDA.jl supports isbits-union arrays. Checking for `allocatedinline`
would be better, but let's just do away with the check entirely and have
the array constructor fail in the presence of unsupported element types.
This is better anyway, as some back-ends may not support isbits-unions.
We do however still check for Union{}, as that isn't allocated inline
so would fail array construction. By using Nothing there instead, we give
the GPU kernel (which is expected to throw an error) the chance to execute
and report an exeception dynamically. This also makes it possible to
trace a broadcast invocation under, e.g., Cthulhu.
maleadt
force-pushed
the
tb/broadcast_errors
branch
from
2016492
to
1410f8c
Compare
maleadt
force-pushed
the
tb/broadcast_errors
branch
from
38b97c2
to
30a96d9
Compare
|
Strange. This was merged into master, but I still get the same error: |
|
Then you're not using GPUArrays#master. Check |
|
... I see. The dependence of |
|
Yeah, that's normal. You don't automatically get commits from master branches until a version has been released, or unless you specifically request those changes. Would you expect otherwise? |
|
;-) No. But then I did not really notice that this change was not a change to the master of |
We are currently checking for
isconcretetype, which is too limiting, as e.g. CUDA.jl supports isbits-union arrays. Checking forallocatedinlinewould be better, but let's just do away with the check entirely and have the array constructor fail in the presence of unsupported element types. This is better anyway, as some back-ends may not support isbits-unions.We do however still check for Union{}, as that isn't allocated inline so would fail array construction. By using Nothing there instead, we give the GPU kernel (which is expected to throw an error) the chance to execute and report an exeception dynamically. This also makes it possible to trace a broadcast invocation under, e.g., Cthulhu.