-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text/latex MIME type in LaTeXWriter #1709
Conversation
Thanks. Instead of duplicating this code, perhaps it can be moved to |
This is an identical bugfix fo JuliaDocs#1518, which was only applied to the HTML writer.
28c8b34
to
3db794a
Compare
It seems like |
Okay I took another pass at this. And after digging through to understand the code a little more, I think it can be simplified to just write out the It seems to make PDFs nicely, and it passes tests: |
The good news is, with this PR, the entire JuMP documentation builds! Lots of code, lots of examples, lots of plots. |
Great, thanks! |
If there's an explicit
text/latex
MIME, then we should just write that directly. There's no point attempting to round-trip it through the intermediate Markdown representation.Closes #1401
Closes #1346
This was motivated by jump-dev/JuMP.jl#1881, which is an attempt to build the full JuMP documentation to PDF. There's a lot of math/latex trickery involved, which is why we're running into issues.