-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize strict
#1689
Generalize strict
#1689
Conversation
What this does:
I am happy with it from my end and am ready for review when you get a chance. |
Bump |
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would be good to document somewhere what the different options for symbols are.
Co-authored-by: Albin Heimerson <albheim@hotmail.com>
The list is in the docstring (https://github.com/JuliaDocs/Documenter.jl/pull/1689/files#diff-2c620811ba00ffd5e7b818bdefbab47fe9d7e3e11d046e6fe18e5c01fdff3f0cR227) but maybe you’re saying the meaning of them all should be documented too? That would make sense to me, though I’m not sure where to put it. |
CI failures seem to be pkg server issues. (Especially considering everything passed just before and the only difference was typos in a docstring). |
Bump :). Would love to get this in soon-- I think it would massively increase the usability of doctests if there was an easy way to make them fail the built without also making everything else fatal. |
Bump |
awesome, thanks @fredrikekre! |
Fixes #1686 by generalizing strict to accept a symbol or vector of symbols. I was going to do just
doctest
but looking at it, it seemed about as easy to do all of them.I only found tests with
strict
for doctests though, but I modified those to try some of the new versions.