Remove double doctest run, add strict doctest #560
Conversation
|
Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions/runs/1342389273?check_suite_focus=true for more details. |
|
This seems like a good idea, reducing CI time is always welcome :) |
| @@ -30,7 +30,13 @@ println("Making docs") | |||
| makedocs(modules=[ControlSystems], | |||
| format=Documenter.HTML(), | |||
| sitename="ControlSystems.jl", | |||
| #strict=true, | |||
| strict=[ | |||
There was a problem hiding this comment.
Don't know exactly which ones we want here, they are not well explained but the names are decently explanatory. See https://github.com/JuliaDocs/Documenter.jl/pull/1689/files#diff-2c620811ba00ffd5e7b818bdefbab47fe9d7e3e11d046e6fe18e5c01fdff3f0cR227
There was a problem hiding this comment.
I think the ones you have chosen seem appropriate. I guess :setup_block always leads to downstream failures if it fails in a meaningful way.
Me might want to check :cross_references?
|
Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions/runs/1431106250?check_suite_focus=true for more details. |
A recently merged PR in Documenter.jl allows for setting strict checking on certain errors.
We currently ran doctest by itself first before running it when generating documentation, I think this means we would not need to.
Just testing this for now, might need to figure out which errors we should use.