-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports for 0.26.2 #1525
Merged
Merged
Backports for 0.26.2 #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8f8c493)
* Mention that push_review doesn't work from forks * Check for empty DOCUMENTER_KEY/GITHUB_TOKEN/GITHUB_ACTOR * Clarify that deploy token and key are not both needed (cherry picked from commit 4b655e7)
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com> (cherry picked from commit 91e3a04)
(cherry picked from commit 93e253a)
Woo! Yes please on a 0.26.2 release. It should fix things like this in the |
Yep, it's coming (still need to backport #1526 too). I'm planning on tagging on Sunday or Monday morning though, since I'll be away from the computer the whole weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1496, #1511, #1510, #1520, #1518, #1517, #1526, #1527