Do not use isnothing for Julia 1.0 compat
#274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems it was not caught by CI since the Github action is disabled? |
|
Julia 1.0 should also be added to appropriate tests too, right? (BlockDiagonals.jl seems to support 1.0 and already has an integration test, so perhaps that integration test should run on 1.0 too?) |
|
I re-enabled it and triggered it on this PR. |
|
Okay, you are again ahead of me |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 12 12
Lines 347 347
=======================================
Hits 325 325
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#273 broke downstream tests, e.g., in AbstractFFTs, since it broke compatibility with Julia 1.0 (and maybe some other versions as well, I don't remember when
isnothingwas added).This PR should fix it.