Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing the testset name #273

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

theogf
Copy link
Contributor

@theogf theogf commented Mar 8, 2023

Solves #272

Add a keyword argument "testset_name" to test_scalar, test_frule and test_rrule to allow replacing the default name.
It still stays an opt-in option and is mostly useful when f is anonymous and its naming is too large to be displayed correctly.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.14 🎉

Comparison is base (6925da1) 93.51% compared to head (ca519c6) 93.65%.

❗ Current head ca519c6 differs from pull request most recent head 2fd4943. Consider uploading reports for the commit 2fd4943 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   93.51%   93.65%   +0.14%     
==========================================
  Files          12       12              
  Lines         339      347       +8     
==========================================
+ Hits          317      325       +8     
  Misses         22       22              
Impacted Files Coverage Δ
src/testers.jl 91.50% <57.14%> (+0.24%) ⬆️
src/output_control.jl 100.00% <0.00%> (ø)
src/ChainRulesTestUtils.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/testers.jl Outdated Show resolved Hide resolved
src/testers.jl Outdated Show resolved Hide resolved
@oxinabox oxinabox merged commit 7faa720 into JuliaDiff:main Mar 8, 2023
@theogf theogf deleted the testset_name branch March 8, 2023 09:55
@gaurav-arya
Copy link

Is this package meant to work on Julia 1.0? If so I think the isnothing check needs compat handling, see the broken tests on AbstractFFTs.jl

@gaurav-arya
Copy link

@devmotion is way ahead of me:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants