Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use digits=5 (not sigdigits) to generate nice random numbers. #207

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 13, 2021

Fixes #206

There were 3 problems:

  • sigdigits was used rather than digits which meant that numbers like 0.0000000000001234 were showing up.
  • the rng which was in the test to reduce chance of hitting edge cases unexpectedly wasn't used
  • that rng wasn't initialized so didn't actually serve that purpose anyway

I have now run these tests a few million times, rather than the 50 that is there, and it always passes now.

@oxinabox oxinabox added the bug Something isn't working label Aug 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #207 (6eb3529) into master (ae32599) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files          11       11           
  Lines         289      289           
=======================================
  Hits          263      263           
  Misses         26       26           
Impacted Files Coverage Δ
src/rand_tangent.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae32599...6eb3529. Read the comment docs.

Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@oxinabox oxinabox merged commit 20db52a into master Aug 13, 2021
@simeonschaub simeonschaub deleted the ox/short branch August 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'niceness of priting' test failure on Julia 1 - ubuntu-latest - x64
3 participants