use digits=5 (not sigdigits) to generate nice random numbers. #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206
There were 3 problems:
sigdigits
was used rather thandigits
which meant that numbers like0.0000000000001234
were showing up.rng
which was in the test to reduce chance of hitting edge cases unexpectedly wasn't usedrng
wasn't initialized so didn't actually serve that purpose anywayI have now run these tests a few million times, rather than the 50 that is there, and it always passes now.