Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'niceness of priting' test failure on Julia 1 - ubuntu-latest - x64 #206

Closed
glennmoy opened this issue Aug 13, 2021 · 2 comments · Fixed by #207
Closed

'niceness of priting' test failure on Julia 1 - ubuntu-latest - x64 #206

glennmoy opened this issue Aug 13, 2021 · 2 comments · Fixed by #207

Comments

@glennmoy
Copy link

https://github.com/JuliaDiff/ChainRulesTestUtils.jl/runs/3318210603?check_suite_focus=true

niceness of printing: Test Failed at /home/runner/work/ChainRulesTestUtils.jl/ChainRulesTestUtils.jl/test/rand_tangent.jl:113
  Expression: length(string(rand_tangent(1.0f0))) <= 12
   Evaluated: 13 <= 12
Stacktrace:
 [1] macro expansion
   @ ~/work/ChainRulesTestUtils.jl/ChainRulesTestUtils.jl/test/rand_tangent.jl:113 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [3] macro expansion
   @ ~/work/ChainRulesTestUtils.jl/ChainRulesTestUtils.jl/test/rand_tangent.jl:109 [inlined]
 [4] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [5] top-level scope
   @ ~/work/ChainRulesTestUtils.jl/ChainRulesTestUtils.jl/test/rand_tangent.jl:8
@simeonschaub
Copy link
Member

I have seen this spring up in PkgEval as well. What does this actually test?

@oxinabox
Copy link
Member

There is special code that makes sure that rand_tangent only generates tangents that can be printed fairly compactly.
It does things like rounding in base 2 to a specific number of significant digits.
It seems like it doesn't always work, (which would be an issue with Base).
Or perhaps just the bounds on those tests are wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants