Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging framework for STDOUT calls #194

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Conversation

zundertj
Copy link
Contributor

I hope you are oke with basically redoing #156? Not sure Manifest changes should be in here, they were added when adding Logging.

Effectively also closes #92.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #194 into master will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   73.19%   73.17%   -0.03%     
==========================================
  Files           6        6              
  Lines         332      328       -4     
==========================================
- Hits          243      240       -3     
+ Misses         89       88       -1
Impacted Files Coverage Δ
src/lcov.jl 86.79% <100%> (ø) ⬆️
src/coveralls.jl 27.86% <66.66%> (-0.71%) ⬇️
src/Coverage.jl 84.9% <66.66%> (ø) ⬆️
src/codecovio.jl 88.33% <66.66%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6124f...5465d3b. Read the comment docs.

@zundertj
Copy link
Contributor Author

zundertj commented Mar 2, 2019

I have resolved the merge conflicts. I do see there is an error related to MbedTLS, which I believe has nothing to do with this PR. Could anyone review this PR, please?

@ararslan
Copy link
Member

ararslan commented Mar 2, 2019

I do see there is an error related to MbedTLS, which I believe has nothing to do with this PR

Correct, that's JuliaLang/MbedTLS.jl#193.

Remove logging entry from Project.toml

Remove using Logging lines; Logging is in Base.
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@ararslan ararslan merged commit 109b103 into JuliaCI:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output is pretty verbose
4 participants