Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging infrastructure instead of prints #156

Closed
wants to merge 1 commit into from
Closed

Use logging infrastructure instead of prints #156

wants to merge 1 commit into from

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan ararslan requested a review from kshyatt January 25, 2018 00:04
kshyatt
kshyatt requested changes Jan 25, 2018
View reviewed changes
Copy link
Collaborator

@kshyatt kshyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your next task is to integrate @test_warn rather than hiding a bunch of stuff in a redirect_stdout in the test files >:)

@kshyatt
Copy link
Collaborator

kshyatt commented Jan 26, 2018

Going to close/reopen to re-run CI.

@kshyatt kshyatt closed this Jan 26, 2018
@kshyatt kshyatt reopened this Jan 26, 2018
@fingolfin
Copy link
Member

I am afraid this now has major conflicts, due to recent changes in master. But perhaps you'd be willing to rebase it anyway?

@zundertj zundertj mentioned this pull request Jan 15, 2019
Merged
@ararslan
Copy link
Member Author

ararslan commented Mar 2, 2019

Superceded by #194.

@ararslan ararslan closed this Mar 2, 2019
@ararslan ararslan deleted the aa/logging branch March 2, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyatt kshyatt kshyatt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @kshyatt @fingolfin