Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure #51

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Fix CI failure #51

merged 4 commits into from
Feb 20, 2023

Conversation

OkonSamuel
Copy link
Member

@OkonSamuel OkonSamuel commented Feb 20, 2023

Note:
Remember to squash merge.

closes #42

@codecov-commenter
Copy link

Codecov Report

Merging #51 (04370c8) into dev (36882f1) will not change coverage.
The diff coverage is n/a.

❗ Current head 04370c8 differs from pull request most recent head 0a8242d. Consider uploading reports for the commit 0a8242d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              dev      #51   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files          12       12           
  Lines         206      206           
=======================================
  Hits          151      151           
  Misses         55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OkonSamuel
Copy link
Member Author

@ablaom. This should fix the ci failure. We no longer need the hack as the Julia issue linked in #42 has been closed.
The failures left are unrelated to ci and are fixed in #50

@OkonSamuel OkonSamuel changed the title check code Fix CI failure Feb 20, 2023
@OkonSamuel OkonSamuel merged commit 6dd8696 into dev Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem installing python scikit-learn in CI
2 participants