-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update code to support sklearn v1.2 #50
Conversation
@tylerjthomas9 I am pinging you here to make sure we avoid any duplication of effort on this front, as I know you are also working on a fork of this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's be sure to:
- Check CI log for any persistent warnings
once that is passing.
I have opened a PR at cstjean/ScikitLearn.jl#119. This PR should pass once that PR is merged. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #50 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 12 12
Lines 206 206
=======================================
Hits 151 151
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Some warning in the ci can't be fixed at the moment except I remove the |
The CI log is showing some deprecation warnings. @OkonSamuel Can you please comment on these. |
Okay, as per zoom call, we'll not address those dep warnings yet. |
At the time of opening the PR the latest version of python's scikitlearn is v1.2.1. In line with this new version the following changes have been made.
normalize
parameter have been removed from the following linear modelsARDRegressor
BayesianRidgeRegressor
ElasticNetRegressor
ElasticNetCVRegressor
LassoRegressor
LassoCVRegressor
LinearRegressor
MultiTaskElasticNetRegressor
MultiTaskElasticNetCVRegressor
MultiTaskLassoRegressor
MultiTaskLassoCVRegressor
RidgeCVClassifier
RidgeClassifier
normalize
parameter of the following linear models has been set asfalse
, but will be removed when python scikitlearn v1.4 is released.OrthogonalMatchingPursuitRegressor
OrthogonalMatchingPursuitCVRegressor
LarsRegressor
LarsCVRegressor
LassoLarsCVRegressor
LassoLarsICRegressor
The
base_estimator
parameter inAdaBoostRegressor
,AdaboostClassifier
,BaggingRegressor
,BaggingClassifier
andRANSACRegressor
models has been renamed toestimator
.The
absolute_loss
andsquared_loss
losses has been replaced by the equivalentabsolute_error
andsquared_error
respectively.Depreciate the
auto
option formax_features
inRandomForestRegressor
,RandomForestClassifier
,ExtraTreesRegressor
andExtraTreesClassifier
models. The new default formax_features
has been set tosqrt
.Replace the
ls
loss with the equivalentsquared_loss
error. Set the default value ofloss
parameter in theGradientBoostingRegressor
model tosquared_loss
Default value for
criterion
inRandomForestRegressor
andExtrasTreesRegressor
models has been set tosquared_loss
. New losses such asfriedman_mse
andpoisson
has been added to the list of possible options forcriterion
log_loss
has been added to the list of possible option for thecriterion
parameter inRandomForestClassifier
andExtrasTreesClassifier
models.The
lad
loss in theGradientBoostingRegressor
model has been replaced by the equivalentabsolute_error
lossAdditionally
mae
loss was removed from the possible options for thecriterion
parametermse
was replaced with the equivaledsquared_error
and,friedman_mse
was added to the possible options for thecriterion
parameter."log_loss"
loss as one of the possible options to theloss
parameter in theProbalisticSGDClassifier
andSGDClassifier
models.loss
parameter inProbalisticSGDClassifier
model from"log"
to"log_loss"
.algorithm
parameter inKMeans
model from"auto"
to"lloyd"
.see https://scikit-learn.org/stable/whats_new/v1.0.html#changes-1-0 and
https://scikit-learn.org/stable/whats_new/v1.0.html