-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Add new method to connect to a SSIDPrefix protected only once, Android: Try to address issue #303 #377
Conversation
ANDROID: Try to fix a network problem in concurrent connections (thanks to WiFiFlutter)
I guess it has some conflicts for this MR |
sorry where? |
Hi @notjulian why did you add timeout for removeWifiNetwork and disconnect on Android? Can you please add a check like this if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { } and use the old behavior elsewhere? |
Hi, |
Hi @notjulian, sorry but what do you mean with "avoid timeout on disconnect"? In @JuanSeBestia library code on disconnect/removeWifiNetwork is there any timeout... you've added it on your pr, but I can't understand what is the purpose of adding a timeout on disconnect/removeWifiNetwork. Thank you |
If the disconnect take more time to complete, it will cancel and return |
@JuanSeBestia Hey, we already have 2 months of this PR, can we continue with the merge? |
I can't. Rebase from master and solve conflicts please |
FYI still "This branch cannot be rebased due to conflicts" |
@JuanSeBestia can you please check I've this: thanks PS: can be related to this: 27521 ? |
I can squash and merge if you want, but maybe it remove you as a commit owner, you can squash by you own if you want |
Mhe I will just merge it, sorry for the delay. |
yes can I do it or is too late now? |
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
For issue #303, I've tested it on a Pixel 7 running Android 14, as well as on other brands.
The fix is taken from WiFiFlutter concurrent-connections
Thanks to: @Martichou, @darhaywa and @daadu
Code example (for a hotspot without Internet), first connect, then forceWifiUsage true, before disconnect forceWiFiUsage to false