ANDROID: Timeout parameter on connectToProtectedSSID method

[alexma01]

In this PR, a timeout parameter has been added to the connectToProtectedWifiSSID method.
The parameter, as methods are made today, is mandatory. If set to null then by default it will use a 15 second timeout for the connection. The parameter is to be used in seconds and not in milliseconds, the conversion is done in the method.
The timeout was added only for Android, as I didn't encounter any problems on IOS.
This PR was created because, when we try to connect to a network by entering an incorrect password, the ANDROID system takes too long to return a response.

[alexma01]

@gustavoabel @JuanSeBestia @eliaslecomte @gitisaac

[gustavoabel]

@alexma01 Could you give more details about the change in the description of this PR? (example: added a timeout to connectToProtectedSSID for this or that)

[alexma01]

Hi @gustavoabel , i added more details!
Thanks!

[JuanSeBestia]

Looks a BREAKING CHANGE for previous users, I was thinking that maybe changes props like

onnectToProtectedSSID(
    SSID: string,
    password: string | null,
    options?: {
      isWEP?: boolean,
      isHidden?: boolean,
      timeout?: number | null
    })

Soo to avoid breaking change could you make the parameter optional?

[JuanSeBestia]

Suggested change

	timeout: number | null
	timeout?: number | null

[alexma01]

Hi @JuanSeBestia,
with the change you suggest we still make BREAKING CHANGES for previous users.
this would require ad hoc work. It would be better to do this in a separate PR.
what do you think?

[JuanSeBestia]

Yep, but I prefer one breaking change and not many on the future, this days comes now, because #362 is having conflicts with this MR for the same reason.

[gustavoabel]

Looks a BREAKING CHANGE for previous users, I was thinking that maybe changes props like

onnectToProtectedSSID(
    SSID: string,
    password: string | null,
    options?: {
      isWEP?: boolean,
      isHidden?: boolean,
      timeout?: number | null
    })

Soo to avoid breaking change could you make the parameter optional?

Can we continue this way? @alexma01 @JuanSeBestia

[JuanSeBestia]

Yep, but I not have too much time free to implement it :(

[alexma01]

Hi guys,

so, i added new method "connectToProtectedWifiSSID":

type ConnectToProtectedSSIDParams = {
    ssid: string;
    password: string | null;
    isWEP?: boolean;
    isHidden?: boolean;
    timeout?: number;
};

export function connectToProtectedWifiSSID(
    options: ConnectToProtectedSSIDParams
): Promise<void>;

This is to maintain backwards compatibility and also because method overloading doesn't work with the react-native javascript bridge.
Let me know if this works.

@JuanSeBestia @gustavoabel

[gustavoabel]

Hi guys,

so, i added new method "connectToProtectedWifiSSID":

type ConnectToProtectedSSIDParams = {
    ssid: string;
    password: string | null;
    isWEP?: boolean;
    isHidden?: boolean;
    timeout?: number;
};

export function connectToProtectedWifiSSID(
    options: ConnectToProtectedSSIDParams
): Promise<void>;

This is to maintain backwards compatibility and also because method overloading doesn't work with the react-native javascript bridge. Let me know if this works.

@JuanSeBestia @gustavoabel

Looks good to me @alexma01

[alexma01]

Hi,

can i have a feedback?
If the implemantion isn't ok, i can change that.

Thanks 😁

@JuanSeBestia

[JuanSeBestia]

Looks good to me, I don´t know if it works also on android, I didn't see the mapping also on the android part, But I agree with how deal with the issue :)

[gustavoabel]

Hi @alexma01, has conflicts here.

[alexma01]

Hi @gustavoabel ,

conflicts resolved.

Thanks

[gustavoabel]

LGTM

[gustavoabel]

@JuanSeBestia
Can I merge this PR?

[JuanSeBestia]

I think yes

[JuanSeBestia]

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀