fix/tw-classnames-output-#627

[PatrykKuniczak]

* Please fill in the required items.

Priority*

• High: This PR needs to be merged first for other tasks.
• Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
• Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I can't open PR to fork, that's why i created this PR.

This is related to #627.

I fixed that fix :)

Solution from #627 wasn't good enough because of the never ending build and it's still don't work properly.

Changes*

I added concurrently for run both watch scripts on the same time, now it was running independly.

Without that, only first script works.
If i placed vite first then tailwind output file wasn't regenerated.
Else Vite don't run and HMR don't refresh page.

I added also -m flag, for minify output file.

And i added dist folder inside content-ui

How to check the feature

Edit files from content-ui page.

[codergigachad]

My solution was a beginner solution, thanks for fixing it like an expert.

[PatrykKuniczak]

My solution was a beginner solution, thanks for fixing it like an expert.

Thanks, but i don't feel like an expert.

You've found that issue, which we're not aware, that's also very helpful 😄

[Jonghakseo]

😄

[Jonghakseo]

I saw above error message. How about moving it inside src, the original file's location, instead of the dist folder?

Is there a reason you moved the output file to dist?

Suggested change

	"build:tailwindcss": "pnpm dlx tailwindcss -i ./src/tailwind-input.css -o ./dist/tailwind-output.css -m",
	"build:tailwindcss": "pnpm dlx tailwindcss -i ./src/tailwind-input.css -o ./src/tailwind-output.css -m",

[PatrykKuniczak]

@Jonghakseo I want to separate output file from src, and there's entire /dist ignored.

[Jonghakseo]

• Add Hook to Compile Tailwind-Output on PMPM Install #608

Like the PR above, It seems like a good idea to exclude from VSC for output files.
How about moving it inside src and out of vsc?

[PatrykKuniczak]

@Jonghakseo What do you mean about 'out of vsc'?

[PatrykKuniczak]

That bug occur probably because of the lack of &
In build-watch script:
development & pnpm build:tailwindcss

Not it's done by concurrently

And i check it a minute ago on VSC, and works perfect, postinstall isn't necessary.

[Jonghakseo]

For me, I still see the above error message.
I just run pnpm dev after pnpm clean and I can see it right after.

@PatrykKuniczak

[PatrykKuniczak]

@Jonghakseo Yeah, that's reproducible, i need to fix it.

[PatrykKuniczak]

@Jonghakseo Ok, I added a tw prebuild before, postinstall can't solve that issue, but this kind of prebuild did it.

[Jonghakseo]

I'm gonna check it!

[Jonghakseo]

HMR was not working. so i fixed it.

fix: use dev env

[Jonghakseo]

Suggested change

	import tailwindcssOutput from '../dist/tailwind-output.css?inline';
	import tailwindcssOutput from '@src/tailwind-output.css?inline';

This is related to the comment above.

[codergigachad]

@PatrykKuniczak any progress here? cause this is very important.

[PatrykKuniczak]

@PatrykKuniczak any progress here? cause this is very important.

We're waiting for @Jonghakseo review

[PatrykKuniczak]

@codergigachad OO maybe he done review, before my message, i'm on mobile then and don't see all messages :)

I will take a look to merge it today.

[PatrykKuniczak]

@Jonghakseo I belived i had to check, because i was thinking if this env will be resolved properly.

Good to you, thank for the second check ❤️