Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax error in pages/content-ui/package.json #627

Closed
wants to merge 1 commit into from

Conversation

codergigachad
Copy link
Contributor

@codergigachad codergigachad commented Aug 3, 2024

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Tailwind build was not working in content-ui during hmr due to syntax error.

Changes*

Changed the package.json file of pages/content-ui

Tailwind build was not working in content-ui during hmr due to syntax error.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We will check and reply to you as soon as possible.

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codergigachad

Can you explain exactly what problem you're trying to solve? I'm wondering what the syntax error is referring to, and what the issue is.

Is it an issue with Windows?

@PatrykKuniczak
Copy link
Collaborator

@Jonghakseo It works perfect for Win also.
IDN what's the reason of this PR

@codergigachad
Copy link
Contributor Author

During hot module reload the changed tailwind classes inside content scripts doesn't build in the css file because of wrong build command in package.json. It doesn't work for me in windows but after I change it to these commands with pnpm dlx it starts to work.

@PatrykKuniczak PatrykKuniczak added bug Something isn't working high priority labels Aug 13, 2024
@PatrykKuniczak PatrykKuniczak mentioned this pull request Aug 13, 2024
3 tasks
@PatrykKuniczak
Copy link
Collaborator

@codergigachad I see the issue right now, but it's not that easy to fix it, as you done.

You put --watch into build:tailwindcss what's cause never ending build.

I fixed it in #654.

I need to close it, because it's fork, i wanted to open PR, to this but it isn't possible, and i don't want to push my commits here 😄

I hope, you won't feel gutted, and want to contribute more 😸

@codergigachad
Copy link
Contributor Author

No problem, I like this repo and I would like to contribute in the future as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants