-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crop horizontally when aspect ratio is reduced without width or height #753
fix: crop horizontally when aspect ratio is reduced without width or height #753
Conversation
🦋 Changeset detectedLatest commit: cfa18c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 93.93% 94.31% +0.37%
==========================================
Files 34 34
Lines 791 791
Branches 225 226 +1
==========================================
+ Hits 743 746 +3
+ Misses 48 45 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@geigerzaehler thanks for this. I went through all the dependency updates today and updated vitest to version 2, which changed all the snapshot files. Can you rebase this PR against the latest commit from Thanks! |
862cb14
to
ad550f0
Compare
Of course, done. |
When the aspect ratio is reduced and no width or height are given the image is now correctly cropped.
Before, if I requested an aspect ratio of 1:2 for an image with dimensions 640x800 it would not change the dimensions of the image. Now the image is correctly cropped to 400x800.