fix: crop horizontally when aspect ratio is reduced

JonasKruckenberg · Nov 27, 2024 · ad550f0 · ad550f0
1 parent 6f2516e
commit ad550f0
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/.changeset/fuzzy-beers-hang.md b/.changeset/fuzzy-beers-hang.md
@@ -0,0 +1,5 @@
+---
+'imagetools-core': patch
+---
+
+Reducing the aspect ratio without providing width or height works correctly now
diff --git a/...mage_snapshots__/resize-spec-ts-aspect-transform-w-crop-horizontally-1-snap.png b/...mage_snapshots__/resize-spec-ts-aspect-transform-w-crop-horizontally-1-snap.png
diff --git a/packages/core/src/transforms/__tests__/resize.spec.ts b/packages/core/src/transforms/__tests__/resize.spec.ts
@@ -283,6 +283,16 @@ describe('aspect', () => {
       expect(await image.toBuffer()).toMatchImageSnapshot()
     })
 
+    test('w/ crop horizontally', async () => {
+      //@ts-expect-error we know this is safe
+      const { image } = await applyTransforms([resize({ aspect: '1:2' }, dirCtx)], img)
+
+      const { width = 0, height = 0 } = await sharp(await image.toBuffer()).metadata()
+      expect(width / height).toEqual(1 / 2)
+
+      expect(await image.toBuffer()).toMatchImageSnapshot()
+    })
+
     test('w/ fit', async () => {
       //@ts-expect-error we know this is safe
       const { image } = await applyTransforms([resize({ aspect: '4:3', fit: 'contain' }, dirCtx)], img)

diff --git a/packages/core/src/transforms/resize.ts b/packages/core/src/transforms/resize.ts
@@ -74,7 +74,7 @@ export const resize: TransformFactory<ResizeOptions> = (config, context) => {
         finalWidth = originalWidth
       } else {
         finalHeight = originalHeight
-        finalWidth = originalHeight / aspect
+        finalWidth = originalHeight * aspect
       }
     } else if (width && height) {
       // width & height BOTH given, need to look at fit