Display user feedback when IPFS fails to provide annotations #3396
Conversation
danbr
changed the title
|
@danbr Here are the paddings from the design. 14px left and right, 24px top and bottom.
|
danbr
force-pushed
the
fix/3237-failing-annotations-feedback
branch
from
ebad860 to
ec98a50
Compare
|
@arrenv After a little more finessing.....
|
| to={location.pathname} | ||
| text={MSG.reloadLink} | ||
| className={styles.link} | ||
| onClick={() => window.location.reload(false)} |
There was a problem hiding this comment.
@arrenv correct. Its superfluous - I will remove.
| @@ -0,0 +1,34 @@ | |||
| .main { | |||
| padding: 20px 14px 20px 14px; | |||
There was a problem hiding this comment.
you can just do padding: 20px 14px
| return ( | ||
| <div className={getMainClasses(appearance, styles)}> | ||
| <FormattedMessage {...label} values={labelValues} /> | ||
| <FormattedMessage {...description} values={descriptionValues} /> |
There was a problem hiding this comment.
Both for label and for description your types give string as an option and you can't destructure a string. You either need to change types to restrict it to only MessageDescriptor, or you call it depending on what type the prop is (similar to some other core components)
There was a problem hiding this comment.
I think you should make them a MessageDescriptor required type. I'm not seeing this being used with simple strings anyway
| @@ -0,0 +1,61 @@ | |||
| **Description** | |||
There was a problem hiding this comment.
Very cool of you to add a styleguide entry for this, but I think we're going to discontinue this. (unless you guys have other opinions on this)
Leave it in for now
| return ( | ||
| <div className={getMainClasses(appearance, styles)}> | ||
| <FormattedMessage {...label} values={labelValues} /> | ||
| <FormattedMessage {...description} values={descriptionValues} /> |
There was a problem hiding this comment.
I think you should make them a MessageDescriptor required type. I'm not seeing this being used with simple strings anyway
|
|
||
| const annotationMessage = getAnnotationMessage(); |
There was a problem hiding this comment.
Maybe add a spinner loader while trying to fetch / parse the IPFS hash (and subsequent object)
Description
This PR displays a warning to update the user when IPFS is uncontactable and does not return annotations for the annotation hash provided.
No IPFS connection:
With IPFS connection:
To promote simplification and standardisation, I have created a CalloutCard component to display the message. This new generic component is very configurable and can be used in exiting situations, such as Confusable warnings ( i will create a new issue to search & replace), and should be considered for use in new dev.
Resolves #3237