Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to retrieve annotations shows no feedback to user #3237

Closed
arrenv opened this issue Mar 11, 2022 · 0 comments · Fixed by #3396
Closed

Failing to retrieve annotations shows no feedback to user #3237

arrenv opened this issue Mar 11, 2022 · 0 comments · Fixed by #3396
Assignees
Labels

Comments

@arrenv
Copy link
Member

arrenv commented Mar 11, 2022

Steps to reproduce

Related issue: #2777

  1. To simulate locally, set ipfsDataJSON to false:
    const { data: ipfsDataJSON } = useDataFetcher(
    ipfsDataFetcher,
    [hash],
    [hash],
    );

Expected behaviour

  • Annotations should not fail silently, there should be a warning to show that annotations didn't load.

This component should already exists in the DApp, so, reuse it. The copy to use is as follows:

Attention. Unable to connect to IPFS gateway, annotations not loaded. Reload to try again.

Figma Link

Screenshot 2022-03-11 115754

Actual behaviour

  • Annotations fail silently, and there is no indication that there were any annotations made on an action / motion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants