Fix logic for motionDomainId in Payment & Permissions dialogs #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrenv
approved these changes
Dec 28, 2021
ArmandoGraterol
approved these changes
Jan 13, 2022
chinins
force-pushed
the
fix/3074-correct-dialogs-motion-domain-id
branch
from
b23e6a8 to
c1faee2
Compare
rdig
approved these changes
Jan 19, 2022
chinins
force-pushed
the
fix/3074-correct-dialogs-motion-domain-id
branch
from
c1faee2 to
67dd589
Compare
|
@rdig, thank you! I've tested again and it's all working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the motion domain ID that is sent by the dialog to the saga.
To test it you need to create a payment & permissions motion in different domains (at least Root & another domain) by changing From domain (and not directly motion domain ID). This should change the motion domain id. You then need to log the values sent to the saga (on master there is another bug that doesn't display correct domain ids in the motions, this is being fixed by a separate PR #3073
@rdig, I would like a review from you at some point as it touches the code that you were implementing (if I recall correctly). I would like to make sure that I am not misunderstanding the logic and the implementation.
Resolves #3074