Fixes motions not appearing in the correct domain in actions list

[arrenv]

Description

Fixes motions correctly appearing in the actions list and actions team filter. See this issue for details #3056.

New stuff ✨

• Adds assignment of ethDomainId to motion action item.
• Adds expectation check to actions motion transformer.

Testing

• Ensure the 'Motions' extension is enabled.
• Create a child team.
• You will need to make sure there is funds and reputation in the team.
• Perform a motion action in the child team and ensure it finishes. You can speed up the time with the following script, this passes 3 days of time. Just run it in your terminal.
  curl -H "Content-Type: application/json" -X POST --data '{"jsonrpc":"2.0","method":"evm_increaseTime","params":[260000],"id": 1}' localhost:8545 && curl -H "Content-Type: application/json" -X POST --data '{"jsonrpc":"2.0","method":"evm_mine","params":[]}' localhost:8545
• Ensure the motion action appears in the list. It may take a second to load after the other actions load.
• Check the domain label of the action.
• Filter the actions by the team, and ensure the motion appears in the list.

Before

After ✨

Resolves #3056

[chinins]

It doesn't seem like it's working for me....

This is the motion I'm creating:

However the motion created in is Root and not the cave of wonders

And here is this motion in the list (and actually the one before was also in the cave of wonders team, I just created another one to double check):

And when i'm filtering by domain neither of the motions are there:

And here is my terminal confirmation that I'm on the correct branch:

[arrenv]

@chinins I thought that may have been a bug, that is why I had trouble replicating the issue initially.

This is a separate issue on allocating the correct team from the dialog, however, I can look into it in this issue as well. What do you think?

This PR is focused on getting the right information from the SubGraph. To create a motion in a domain, you need to select the team before creating the action. See gif below:

[chinins]

@chinins I thought that may have been a bug, that is why I had trouble replicating the issue initially.

This is a separate issue on allocating the correct team from the dialog, however, I can look into it in this issue as well. What do you think?

This PR is focused on getting the right information from the SubGraph. To create a motion in a domain, you need to select the team before creating the action. See gif below:

We had a call with Arren and clarified where my problem was. It seems that there is a bug in CreatePayment dialog that doesn't send correct motion domain to the network. It is indeed a separate issue which I will create.

[chinins]

It's all clear and good now.