Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Serialization #92

Merged
merged 9 commits into from
May 21, 2021
Merged

Conversation

marip8
Copy link
Collaborator

@marip8 marip8 commented Nov 21, 2020

This PR adds serialization to some of the types defined in rct_optimizations

@marip8
Copy link
Collaborator Author

marip8 commented Nov 30, 2020

@schornakj can you review?

Copy link
Contributor

@schornakj schornakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marip8 Looks good in general, just a few questions.

I would also suggest adding some unit tests to at minimum verify that converting various types to YAML and then back again returns the same original value.

rct_optimizations/CMakeLists.txt Show resolved Hide resolved
@drchrislewis
Copy link
Collaborator

@marip8 @schornakj I made some suggestions, but nothing major. I approved, but did not merge.

@marip8 marip8 merged commit eec86d4 into Jmeyer1292:master May 21, 2021
@marip8 marip8 deleted the update/serialization branch May 21, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants