-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Serialization #92
Conversation
297a155
to
542dd6b
Compare
@schornakj can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marip8 Looks good in general, just a few questions.
I would also suggest adding some unit tests to at minimum verify that converting various types to YAML and then back again returns the same original value.
rct_optimizations/include/rct_optimizations/serialization/eigen.h
Outdated
Show resolved
Hide resolved
@marip8 @schornakj I made some suggestions, but nothing major. I approved, but did not merge. |
This PR adds serialization to some of the types defined in
rct_optimizations