Unit Test Determinism #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marip8
force-pushed
the
update/deterministic_unit_tests
branch
from
262593b
to
0f347b7
Compare
marip8
force-pushed
the
update/deterministic_unit_tests
branch
from
0f347b7
to
f1e6da7
Compare
|
@schornakj can you review this as well? |
schornakj
approved these changes
Nov 5, 2020
|
@marip8 Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails somewhat often for this repository due to random number generation in the unit tests producing slightly unacceptable results from time to time. This PR changes the unit tests to be deterministic by providing a constant seed (0) to the various random number generators used throughout the tests. This PR also adds an optional seed parameter to the
DHTransformclass which uses a random number generator to create random joint states