Noise qualification update #65

marip8 · 2020-06-29T22:14:52Z

Changes suggested by @drchrislewis:

Update to use SVD when calculating eigenvectors for quaternion average as it is more numerically stable
Fix the variance calculation to divide by N-1, rather than N

schornakj · 2020-06-30T16:38:18Z

rct_optimizations/src/rct_optimizations/validation/noise_qualification.cpp

+  * "The solution of this maximization problem is well known. The average quaternion is
+  * the eigenvector of M corresponding to the maximum eigenvalue."


Are these "editorial" kinds of quotes?

That was a quote that I pulled directly from the paper. I probably should do a better job citing it, but I at least wanted to indicate that that particular comment was not my own

Switched to SVD; updated variance calculation

798d7c2

marip8 merged commit d0cd542 into Jmeyer1292:master Jun 29, 2020

marip8 deleted the update/noise_measurement branch June 29, 2020 22:32

schornakj reviewed Jun 30, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Noise qualification update #65

Noise qualification update #65

marip8 commented Jun 29, 2020

schornakj Jun 30, 2020

marip8 Jun 30, 2020

		* "The solution of this maximization problem is well known. The average quaternion is
		* the eigenvector of M corresponding to the maximum eigenvalue."

Noise qualification update #65

Noise qualification update #65

Conversation

marip8 commented Jun 29, 2020

schornakj Jun 30, 2020

Choose a reason for hiding this comment

marip8 Jun 30, 2020

Choose a reason for hiding this comment