-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial DH Chain Kinematic Calibration functionality #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
schornakj
reviewed
Jun 23, 2020
rct_optimizations/src/rct_optimizations/dh_chain_kinematic_calibration.cpp
Outdated
Show resolved
Hide resolved
marip8
force-pushed
the
feature/dh_chain_kin_cal
branch
2 times, most recently
from
June 30, 2020 15:19
6238d38
to
1485355
Compare
marip8
force-pushed
the
feature/dh_chain_kin_cal
branch
2 times, most recently
from
July 15, 2020 14:43
5d58913
to
d5bc832
Compare
schornakj
suggested changes
Jul 20, 2020
rct_optimizations/include/rct_optimizations/dh_chain_kinematic_calibration.h
Outdated
Show resolved
Hide resolved
marip8
force-pushed
the
feature/dh_chain_kin_cal
branch
from
July 20, 2020 22:00
d5bc832
to
049cf13
Compare
marip8
force-pushed
the
feature/dh_chain_kin_cal
branch
from
July 20, 2020 22:48
e930e79
to
0cc443a
Compare
marip8
force-pushed
the
feature/dh_chain_kin_cal
branch
from
July 20, 2020 22:51
0cc443a
to
9be0e05
Compare
@schornakj is this good to go now? |
schornakj
approved these changes
Jul 21, 2020
@marip8 Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a number of changes to support a minimum working example of calibration of a kinematic chain based on DH parameters with camera and target
getFK
andgetRelativeTransform
) to work easily with auto diffGaussianNoiseDHTransform
since virtual class functions cannot be templatesGaussianNoiseDHTransform
classCurrently the kinematic calibration converges for the perfect cases represented in the unit test, as well as some perturbed cases that I tried. More development is necessary to finish this algorithm, but that should come in a later PR.
This PR replaces #53
TODO