-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to evaluate covariance of optimization results #46
Add functions to evaluate covariance of optimization results #46
Conversation
I wanted to provide some examples of output covariance matrices to make sure these calculations make sense: In all cases the Ceres covariance options are set to:
Circle-Fit OptimizationsIn all cases the optimization is solving for a circle defined by the Observations are noise-free and evenly-spaced:
Observations are noise-free but are tightly clustered within +/- 0.063 radians of two points on opposite sides of the circle at
Observations consist of just two points, at
Observations consist of just two points, at
Just one point is observed at
Intrinsic Camera OptimizationsThis is from the problem set up and solved by Optimization result for reference:
Distortions:
Extrinsic Camera OptimizationsThese are from the Covariance of camera-to-wrist transform:
Covariance of base-to-target transform:
Covariance between camera-to-wrist and base-to-target transforms:
|
I think I figured this out: while the initial conditions of these test cases are randomized, the ground truth values for the base-to-target and wrist-to-camera transforms are the same, so the optimization results for each type of test case are the same regardless of the initial conditions. |
289223f
to
c8e46a2
Compare
@marip8 This is ready for review when you get a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I think it's probably worth thinking about how we print these results such that it's clear which parameter block is across the columns of the matrix and which is across the rows.
rct_optimizations/include/rct_optimizations/covariance_analysis.h
Outdated
Show resolved
Hide resolved
@marip8 I got my CI issues mixed up when we talked earlier today, this one was just failing because of a flaky test. Should be good to go now. |
TODOs: