-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rct_image_tools a pure CMake package #45
Make rct_image_tools a pure CMake package #45
Conversation
62bc6a2
to
4d5449c
Compare
@schornakj do you know why CI hasn't run for this PR? It looks like your branch has the CI config files. Maybe it needs a rebase or we need to close and reopen this PR? |
@marip8 I've read that Github Actions have some poorly-documented limitations that sometimes prevent jobs from running. I need to push up a new commit to trigger the pipeline again. |
B |
@Levi-Armstrong @marip8 The current problem is that the What's the right way to solve this, other than duplicating the creation of my |
7b20a73
to
64d3b69
Compare
64d3b69
to
42167d3
Compare
@marip8 Added a workaround for the Eigen issues I'd been having in the name of getting some of the outstanding PRs resolved. Should be ready to go. |
This depends on #42 and continues to address #35.
rct_image_tools
to be a pure CMake package, instead of a Catkin package.rct_image_tools
libraries through therct::rct_image_tools
target.rct_image_tools
so that they treat it as a CMake package instead of a Catkin package.Eigen3::Eigen
target.rct_common
for package setup.