Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rct_image_tools a pure CMake package #45

Merged

Conversation

schornakj
Copy link
Contributor

@schornakj schornakj commented May 22, 2020

This depends on #42 and continues to address #35.

  • Modify rct_image_tools to be a pure CMake package, instead of a Catkin package.
  • Provide rct_image_tools libraries through the rct::rct_image_tools target.
  • Modify packages that use rct_image_tools so that they treat it as a CMake package instead of a Catkin package.
  • Link against Eigen using the Eigen3::Eigen target.
  • Use the macros in rct_common for package setup.

@schornakj schornakj force-pushed the feature/35-rct-image-tools-pure-cmake branch from 62bc6a2 to 4d5449c Compare May 23, 2020 00:14
@marip8
Copy link
Collaborator

marip8 commented May 26, 2020

@schornakj do you know why CI hasn't run for this PR? It looks like your branch has the CI config files. Maybe it needs a rebase or we need to close and reopen this PR?

@schornakj
Copy link
Contributor Author

@marip8 I've read that Github Actions have some poorly-documented limitations that sometimes prevent jobs from running. I need to push up a new commit to trigger the pipeline again.

@Levi-Armstrong
Copy link
Collaborator

B

@schornakj
Copy link
Contributor Author

@Levi-Armstrong @marip8 The current problem is that the Eigen3::Eigen target isn't provided by default on Xenial. I have a section in rct_image_tools/CMakeLists.txt that creates this target from the Eigen3 definitions and include directories if it isn't found. However, it looks like packages that link against rct_image_tools aren't able to find my Eigen3::Eigen target.

What's the right way to solve this, other than duplicating the creation of my Eigen3::Eigen target in each package that links against rct_image_tools?

@schornakj schornakj force-pushed the feature/35-rct-image-tools-pure-cmake branch from 7b20a73 to 64d3b69 Compare June 2, 2020 21:44
@schornakj schornakj force-pushed the feature/35-rct-image-tools-pure-cmake branch from 64d3b69 to 42167d3 Compare June 24, 2020 18:52
@schornakj
Copy link
Contributor Author

@marip8 Added a workaround for the Eigen issues I'd been having in the name of getting some of the outstanding PRs resolved. Should be ready to go.

@marip8 marip8 merged commit 29d66b3 into Jmeyer1292:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants