Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization testing utilities update #37

Merged
merged 5 commits into from
May 18, 2020
Merged

Optimization testing utilities update #37

merged 5 commits into from
May 18, 2020

Conversation

marip8
Copy link
Collaborator

@marip8 marip8 commented May 13, 2020

This PR updates the optimization testing utilities to improve ease of use for generating simulated correspondences

@marip8
Copy link
Collaborator Author

marip8 commented May 13, 2020

@schornakj can you review when you get the chance?

@marip8 marip8 mentioned this pull request May 14, 2020
Merged
schornakj
schornakj approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@schornakj schornakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just have a few comments where I had questions.

rct_optimizations/include/rct_optimizations/types.h Show resolved Hide resolved
rct_optimizations/test/extrinsic_multi_static_camera_utest.cpp Show resolved Hide resolved
rct_optimizations/test/extrinsic_multi_static_camera_utest.cpp Show resolved Hide resolved
@marip8 marip8 merged commit 5a07b3e into Jmeyer1292:master May 18, 2020
@marip8 marip8 deleted the update/optimization_testing_utilities branch May 18, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schornakj schornakj schornakj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marip8 @schornakj