Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoformatting/linting to vscode #2320

Merged
merged 2 commits into from
Jan 8, 2025
Merged

feat: add autoformatting/linting to vscode #2320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc04bb6
feat: add autoformatting/linting recommendations to vscode
daniellacosse Jan 7, 2025
b2e15d7
separate by language
daniellacosse Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ node_modules
.idea
.task
.vs/
.vscode
*.DS_Store
*.env
*.pdb
Expand All @@ -13,4 +12,4 @@ node_modules
/output
/build

*storybook.log
*storybook.log
5 changes: 5 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"recommendations": [
"dbaeumer.vscode-eslint"
]
}
18 changes: 18 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"eslint.run": "onSave",
"eslint.validate": ["javascript", "typescript"],
"files.insertFinalNewline": true,
"[go]": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to add TS and other languages here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me see if that works

Copy link
Contributor Author

@daniellacosse daniellacosse Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it does. for posterity, the bracket syntax here denotes a "language-specific override" - this is a little better as it scopes the user configs we might be trampling on in the workspace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add Java, Swift, Objective-C here later too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally

"editor.formatOnSave": true
},
"[javascript]": {
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "always"
},
},
"[typescript]": {
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "always"
},
},
}
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@ again.
All submissions, including submissions by project members, require review. We
use GitHub pull requests for this purpose. Consult
[GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
information on using pull requests.
information on using pull requests.

## Setup: VSCode

Make sure to go to the `Extensions` tab and install the recommended extensions!
Loading