Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoformatting/linting to vscode #2320

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

daniellacosse
Copy link
Contributor

Screen.Recording.2025-01-07.at.1.28.57.PM.mov

@daniellacosse daniellacosse requested a review from a team as a code owner January 7, 2025 18:29
@daniellacosse daniellacosse requested a review from fortuna January 7, 2025 18:29
@github-actions github-actions bot added the size/S label Jan 7, 2025
CONTRIBUTING.md Outdated
## Setup: VSCode

Copy the `.vscode.recommended` folder into `.vscode` and edit the contents to your liking.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put it in the /.vscode folder instead, so the developer doesn't need to do anything else. I'd like it to just work on my multiple environments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue with this is that it may conflict with the dev's current setup. People have opinions on whether or not you should be formatting on save, etc. We're okay with this tradeoff? /cc @sbruens

Copy link
Contributor Author

@daniellacosse daniellacosse Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we'll start with committing it and go from there if it becomes an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellacosse daniellacosse requested a review from fortuna January 7, 2025 19:17
@daniellacosse daniellacosse changed the title feat: add autoformatting/linting recommendations to vscode feat: add autoformatting/linting to vscode Jan 7, 2025
@daniellacosse daniellacosse force-pushed the daniellacosse/vscode_autoformat branch from 195a161 to fc04bb6 Compare January 7, 2025 19:22
@github-actions github-actions bot added size/XS and removed size/S labels Jan 7, 2025
"html.validate.scripts": false,
"html.validate.styles": false,
"javascript.validate.enable": false,
"[go]": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to add TS and other languages here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me see if that works

Copy link
Contributor Author

@daniellacosse daniellacosse Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it does. for posterity, the bracket syntax here denotes a "language-specific override" - this is a little better as it scopes the user configs we might be trampling on in the workspace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add Java, Swift, Objective-C here later too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally

@daniellacosse daniellacosse requested a review from fortuna January 7, 2025 21:27
"html.validate.scripts": false,
"html.validate.styles": false,
"javascript.validate.enable": false,
"[go]": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add Java, Swift, Objective-C here later too

@daniellacosse daniellacosse merged commit b48dd2c into master Jan 8, 2025
25 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/vscode_autoformat branch January 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants