-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoformatting/linting to vscode #2320
Conversation
CONTRIBUTING.md
Outdated
## Setup: VSCode | ||
|
||
Copy the `.vscode.recommended` folder into `.vscode` and edit the contents to your liking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put it in the /.vscode
folder instead, so the developer doesn't need to do anything else. I'd like it to just work on my multiple environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue with this is that it may conflict with the dev's current setup. People have opinions on whether or not you should be formatting on save, etc. We're okay with this tradeoff? /cc @sbruens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we'll start with committing it and go from there if it becomes an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
195a161
to
fc04bb6
Compare
"html.validate.scripts": false, | ||
"html.validate.styles": false, | ||
"javascript.validate.enable": false, | ||
"[go]": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to add TS and other languages here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me see if that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it does. for posterity, the bracket syntax here denotes a "language-specific override" - this is a little better as it scopes the user configs we might be trampling on in the workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add Java, Swift, Objective-C here later too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally
"html.validate.scripts": false, | ||
"html.validate.styles": false, | ||
"javascript.validate.enable": false, | ||
"[go]": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add Java, Swift, Objective-C here later too
Screen.Recording.2025-01-07.at.1.28.57.PM.mov