chore(cordova/apple/ios): expand import_messages action to generate iOS strings
#1683
Conversation
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
sbruens
changed the title
import_messages action to generate iOS stringsimport_messages action to generate iOS strings
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return str | ||
| .replace(/"/g, '\\"') | ||
| .replace(/'/g, "\\'") | ||
| .replace(/</g, '\\<') | ||
| .replace(/>/g, '\\>;') | ||
| .replace(/&/g, '\\&'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| return str | ||
| .replace(/"/g, '\\"') | ||
| .replace(/'/g, "\\'") | ||
| .replace(/</g, '\\<') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| return str | ||
| .replace(/"/g, '\\"') | ||
| .replace(/'/g, "\\'") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| return str | ||
| .replace(/"/g, '\\"') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
sbruens
force-pushed
the
sbruens/l10n-ios
branch
from
e2c57b0 to
090075e
Compare
|
|
||
| function escapeXmlCharacters(str) { | ||
| return str | ||
| .replace(/"/g, '\\"') |
There was a problem hiding this comment.
nit: we could probably get all of these in a single pass with reduce
other nit: consider replaceAll https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll
| @@ -5,6 +5,7 @@ import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "OutlineAppleLib", | |||
| defaultLocalization: "en", | |||
| @@ -24,6 +20,8 @@ | |||
| <string>${PRODUCT_NAME}</string> | |||
| <key>CFBundlePackageType</key> | |||
| <string>APPL</string> | |||
| <key>CFBundleShortVersionString</key> | |||
| <string>0.0.0-debug</string> | |||
There was a problem hiding this comment.
I think we should delete this? It's meant to be injected at build time, but I forget
There was a problem hiding this comment.
I believe we only inject in release mode, and we do so by search and replacing the string. Don't remove it. It also makes it clearer what to expect in the generated file and what we get in dev.
Though, I think there's a way to specify the version only once for all targets. To be investigated.
There was a problem hiding this comment.
Ah, looking back at the code, you're right. I wonder how this got removed, maybe it was xcode?
| <key>CFBundleShortVersionString</key> | ||
| <string>0.0.0-debug</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>0</string> |
There was a problem hiding this comment.
same with the bundleversion
| ).end({format: 'object'}).resources.string; | ||
| const ANDROID = 'android'; | ||
| const IOS = 'ios'; | ||
| const VALID_PLATFORMS = [ANDROID, IOS]; |
There was a problem hiding this comment.
do we need macos/maccatalyst?
`node-gyp` versions older than v8.0.0 don't work with Python 3.11.
sbruens
force-pushed
the
sbruens/l10n-ios
branch
from
b0c16d4 to
b1eab9b
Compare
No description provided.