Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move material3-common to COMPOSE_MATERIAL3_COMMON group #1716

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Move material3-common to COMPOSE_MATERIAL3_COMMON group #1716

merged 1 commit into from
Dec 10, 2024

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Dec 9, 2024 •
edited
Loading

  • It has its own versioning
  • we don't pass its version from CI (we should add it in Library.kt)
  • because of this 9999.0.0-SNAPSHOT is published:
    image
    (already removed from dev manually)

@igordmn igordmn requested a review from terrakok December 9, 2024 18:29
@igordmn
Copy link
Collaborator Author

igordmn commented Dec 9, 2024 •
edited
Loading

we don't pass its version from CI (we should add it in Library.kt)

We shouldn't do that yet, because we don't have an associated redirected library. The last version is old https://mvnrepository.com/artifact/androidx.compose.material3/material3-common/1.0.0-alpha01

@igordmn igordmn merged commit 78207b8 into jb-main Dec 10, 2024
7 checks passed
@igordmn igordmn deleted the igordmn-patch-10 branch December 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrakok terrakok terrakok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igordmn @terrakok