Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of selection handles in iOS when text is RTL or BiDi #1331

Merged

made tests more readable

4f3ac09
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix visibility of selection handles in iOS when text is RTL or BiDi #1331

made tests more readable
4f3ac09
Select commit
Loading
Failed to load commit list.
GitHub Actions / iOS CMP Utils tests results succeeded Jun 18, 2024 in 0s

Xcode test results

Testing project CMPUIKitUtils with scheme CMPUIKitUtilsTests

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
990001.07s

Test Summary

CMPUIKitUtilsTests

  • Device: iPhone 15, 17.2 (21C62)
  • SDK: Simulator - iOS 17.0, 17.0
TestTotalSuccessFailureSkippedExpected Failure
test-class CMPViewControllerTests99000

Failure Failures

All tests passed 🎉


Code Coverage

Coverage Covered Executable
CMPUIKitUtilsTestApp.app 64.71 % 198 306
  CMPAccessibilityElement.m 0.00 % 0 69
  CMPOSLogger.m 100.00 % 34 34
  CMPViewController.m 85.15 % 86 101
  CMPOSLoggerInterval.m 100.00 % 14 14
  CMPUIKitUtilsTestApp.swift 100.00 % 64 64
  CMPAccessibilityContainer.m 0.00 % 0 24
libCMPUIKitUtils.a 55.37 % 134 242
  CMPOSLoggerInterval.m 100.00 % 14 14
  CMPOSLogger.m 100.00 % 34 34
  CMPAccessibilityElement.m 0.00 % 0 69
  CMPAccessibilityContainer.m 0.00 % 0 24
  CMPViewController.m 85.15 % 86 101
Total 60.58 % 332 548

Details

Test Details

CMPUIKitUtilsTestsback

CMPViewControllerTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)1.07s
Successtest-method testChildController()
Successtest-method testFullscreenPresentationOnTop()
Successtest-method testFullScreenPresentationSandwich()
Successtest-method testNavigationControllerPresentAndPush2()
Successtest-method testNavigationControllerPresentAndPush()
Successtest-method testNotAttached()
Successtest-method testPresentAndDismiss()
Successtest-method testRootViewController()
Successtest-method testTabBarControllerPresentAndPush()