Fix visibility of selection handles in iOS when text is RTL or BiDi #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
May 2, 2024
MatkovIvan
reviewed
May 2, 2024
...kitMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
May 2, 2024
| internal actual fun TextFieldSelectionManager.isSelectionHandleInVisibleBound( | ||
| isStartHandle: Boolean | ||
| ): Boolean { | ||
| fun getSelectionHandleVisibilityPointPosition(isStartHandle: Boolean): Offset { |
There was a problem hiding this comment.
Also, can we have unit test for this logic?
MatkovIvan
reviewed
May 13, 2024
| val visibleBounds = state?.layoutCoordinates?.visibleBounds() | ||
| val handlePosition = getSelectionHandleVisibilityPointPosition(isStartHandle) | ||
|
|
||
| return visibleBounds?.containsInclusive(handlePosition) ?: false |
There was a problem hiding this comment.
It seems alternative of containsInclusive with HeightToleranceFactor should be defined instead of reinventing getHandlePosition with their corner cases and transformations
There was a problem hiding this comment.
I rewrote it like this because I wanted to make proper check for coordinates of left and right selection handles (line 171), but it seems like it's not worth it.
Figured out how to arrange that properly, I'll rewrite soon. It won't be so simple as you suggested because I still need height for this solution, but it still be simpler than this.
mazunin-v-jb
changed the title
mazunin-v-jb
force-pushed
the
v.mazunin/visibility-of-selection-handles-ios-rtl-ltr
branch
from
9d80da9 to
fd18d36
Compare
MatkovIvan
approved these changes
Jun 10, 2024
ASalavei
reviewed
Jun 11, 2024
| 50.0f, | ||
| Rect(Offset(0f, 0f), Offset(744.0f, 50.0f)) | ||
| ) | ||
| assert(isStartVisible && isEndVisible) |
There was a problem hiding this comment.
- It's better to use
assertTrueorassertFalseto verify visible and invisible results. - please use one assert for every condition, like:
assertTrue(isStartVisible)
assertFalse(isEndVisible)
acd092d to
45c2185
Compare
…, added test screen in Components/TextField with RTL and BiDi examples
…nto separate method, added test cases for that method
mazunin-v-jb
force-pushed
the
v.mazunin/visibility-of-selection-handles-ios-rtl-ltr
branch
from
45c2185 to
4f3ac09
Compare
mazunin-v-jb
deleted the
v.mazunin/visibility-of-selection-handles-ios-rtl-ltr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted check of visibility of selection handles in iOS - they won't be shown when they are visible less than 80% of their size.
This change is required for making selection handles visible when a single line textfield contains LTR + RTL text, before this fix selection handles weren't visible.
In addition, during scrolling the long textfield, selection handles will be hiding more smoothly than before.
Fixes: https://youtrack.jetbrains.com/issue/COMPOSE-1359/iOS-Selection-Handles-work-weirdly-when-text-is-RTL-LTR
Testing
Open the test app, go Android TextField Samples -> Basic input fields, write some LTR text in any textfield with RTL text, then try to select text. Selection Handles should be visible
Release Notes
Fixes - iOS
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.