-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meaningful CSS class to AutosizeInput wrapper div #4573
Add meaningful CSS class to AutosizeInput wrapper div #4573
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 562e9a1:
|
45b99a6
to
537ce8c
Compare
Hey @trumbitta thanks for this PR! We're currently working through the updates we're making for 5.0 (see #4559) and have two thoughts on this:
Will update you shortly with how this is going |
537ce8c
to
562e9a1
Compare
Hey @JedWatson thanks for the heads-up! While you decide about the best course of action, I thought I'd better help by doing what I could and so I updated the name to |
@trumbitta just wanted to say thanks for this PR. One of the goals moving into a new major version was to identify any breaking changes and autosizeinput was one of those long overdue changes. Much of the Input component was thus overhauled as a part of this PR. #4625 The impact of the referenced PR is that it duplicates this functionality. Some other things to note:
That all said, I agree with the intention of this PR, but will close this as this functionality will is included as a part of another PR. |
Hey, thanks for the heads-up! I'm excited for the upcoming release, but at the same time I don't know when I will be able to use it since a sizable slice of our users unfortunately still uses IE11. Is there any chance you'll release a patch version with this PR before going forward with the next major? 🤞🤞🤞 |
This little div:
bears some CSS rules that would be much easier to customize (via class name / styled-components) if it had a proper, meaningful, fixed class name.
This little PR adds that class name:
Without it, I'm having to do this:
but I would rather not :D